TS strict (4/4): enable strict mode in base tsconfig#3640
Closed
tegan-temporal wants to merge 1 commit into
Closed
TS strict (4/4): enable strict mode in base tsconfig#3640tegan-temporal wants to merge 1 commit into
tegan-temporal wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tegan-temporal
changed the title
tegan-temporal
changed the title
tegan-temporal
commented
Jul 8, 2026
|
|
||
| <!-- Info Alert --> | ||
| <Alert intent="info" class="text-sm"> | ||
| <Icon name="info" slot="icon" /> |
Contributor
Author
There was a problem hiding this comment.
Alert does not have an icon slot... this wasn't being rendered to begin with. It just became noticeable due to the strictness change
tegan-temporal
changed the title
tegan-temporal
marked this pull request as ready for review
July 17, 2026 00:10
Contributor
|
Hey @tegan-temporal . I know lots of these change are not runtime, but since they're mixed with runtime changes it ends up a being a big PR that needs review. Any chance you want to ship all the stuff that doesn't need real review (tests/types etc) first, which can be insta-approved. Then a second PR could be the runtime changes and get a proper review (~30 files). |
tegan-temporal
force-pushed
the
ts-strict-mode
branch
from
July 17, 2026 16:12
32b11f7 to
5ba024e
Compare
tegan-temporal
changed the title
tegan-temporal
force-pushed
the
strict/3-behavior
branch
from
July 17, 2026 16:46
c174bec to
441f4e9
Compare
tegan-temporal
force-pushed
the
ts-strict-mode
branch
from
July 17, 2026 16:46
5ba024e to
6360cd0
Compare
Flip strict: true and switch the Danger strict-error check from warn to fail.
tegan-temporal
force-pushed
the
strict/3-behavior
branch
from
July 17, 2026 17:36
441f4e9 to
a6e10b3
Compare
tegan-temporal
force-pushed
the
ts-strict-mode
branch
from
July 17, 2026 17:36
6360cd0 to
f1b35f2
Compare
tegan-temporal
added a commit
that referenced
this pull request
Jul 17, 2026
Fold the strict: true flip + Danger warn->fail into this PR. The standalone-activity form's superForm types only resolve correctly under strictNullChecks, so the behavior changes can't type-check on a strict:false main — the flag must land with them. Supersedes the separate flag PR (#3640).
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final of a 4-PR split (was the combined branch). Stacked on
strict/3-behavior(#3688).Enables and enforces strict mode now that PRs 1–3 resolve every error:
strict: trueintsconfig.jsondangerfile.ts) so any strict error in a changed file blocks the PR, with 1-indexed line numbers (scripts/count-strict-errors.ts)The enforcement flip lives here, not in the base PR, so the earlier PRs can merge incrementally without prematurely blocking unrelated PRs while the ~690 errors are still being resolved across the stack.
Stack (merge bottom-up):
strict/1-base— type annotations + dead-code cleanup (zero runtime)strict/2-mechanical— strictNullChecks null-safety guardsstrict/3-behavior— runtime-affecting model/form/service changests-strict-mode— flipstrict: true+ enforce in CISplit verified: stacking all four reproduces the original combined tree byte-for-byte.