Numerical aggregate functions have an option to skip or include nans in calculation, skip by default#8457
Numerical aggregate functions have an option to skip or include nans in calculation, skip by default#8457robert3005 wants to merge 3 commits into
Conversation
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
162.1 µs | 198.5 µs | -18.35% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
274 µs | 308.5 µs | -11.2% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
214.7 µs | 176.5 µs | +21.69% |
| ⚡ | Simulation | chunked_varbinview_opt_into_canonical[(1000, 10)] |
230.1 µs | 192.7 µs | +19.37% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
215.3 ns | 186.1 ns | +15.67% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
275.6 ns | 246.4 ns | +11.84% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/skipnans (5b21a56) with develop (59cf59c)
Footnotes
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
Need to make sure that stats are only ever written with skipnan: true |
…in calculation, skip by default Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
joseph-isaacs
left a comment
There was a problem hiding this comment.
Its good to have options, stats should ignore NaN but the default should be to propergate NaN
Can do this in the future
Almost all of the time you want to skip nans but for rare cases when you don't
we need to be able to configure it