Skip to content

Numerical aggregate functions have an option to skip or include nans in calculation, skip by default#8457

Open
robert3005 wants to merge 3 commits into
developfrom
rk/skipnans
Open

Numerical aggregate functions have an option to skip or include nans in calculation, skip by default#8457
robert3005 wants to merge 3 commits into
developfrom
rk/skipnans

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Almost all of the time you want to skip nans but for rare cases when you don't
we need to be able to configure it

@robert3005 robert3005 requested a review from a team June 17, 2026 09:11
Comment thread encodings/runend/src/compute/min_max.rs Outdated
@robert3005 robert3005 added the changelog/feature A new feature label Jun 17, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 4 improved benchmarks
❌ 2 regressed benchmarks
✅ 1575 untouched benchmarks
⏩ 3 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_canonical_into[(1000, 10)] 162.1 µs 198.5 µs -18.35%
Simulation chunked_varbinview_canonical_into[(100, 100)] 274 µs 308.5 µs -11.2%
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 214.7 µs 176.5 µs +21.69%
Simulation chunked_varbinview_opt_into_canonical[(1000, 10)] 230.1 µs 192.7 µs +19.37%
Simulation bitwise_not_vortex_buffer_mut[128] 215.3 ns 186.1 ns +15.67%
Simulation bitwise_not_vortex_buffer_mut[1024] 275.6 ns 246.4 ns +11.84%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/skipnans (5b21a56) with develop (59cf59c)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005

Copy link
Copy Markdown
Contributor Author

Need to make sure that stats are only ever written with skipnan: true

…in calculation, skip by default

Signed-off-by: Robert Kruszewski <github@robertk.io>
Comment thread encodings/sequence/src/compute/min_max.rs Outdated
Comment thread vortex-array/src/aggregate_fn/fns/max/mod.rs Outdated
Comment thread vortex-array/src/aggregate_fn/fns/max/mod.rs Outdated
Comment thread vortex-array/src/aggregate_fn/fns/min/mod.rs Outdated
Comment thread vortex-array/src/aggregate_fn/fns/min/mod.rs Outdated
Comment thread vortex-array/src/aggregate_fn/fns/min_max/mod.rs Outdated
Comment thread vortex-array/src/stats/expr.rs Outdated
Comment thread vortex-array/src/expr/stats/mod.rs Outdated
Signed-off-by: Robert Kruszewski <github@robertk.io>
Comment thread encodings/sequence/src/compute/min_max.rs
Signed-off-by: Robert Kruszewski <github@robertk.io>
Comment thread fuzz/src/array/min_max.rs

@joseph-isaacs joseph-isaacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its good to have options, stats should ignore NaN but the default should be to propergate NaN

Can do this in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants