Numerical aggregate functions have an option to skip or include nans in calculation, skip by default#8457
Numerical aggregate functions have an option to skip or include nans in calculation, skip by default#8457robert3005 wants to merge 3 commits into
2 benchmarks regressed
⚠️ Unknown Walltime execution environment detected
Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.
For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.
⚡ 4 improved benchmarks
❌ 2 regressed benchmarks
✅ 1575 untouched benchmarks
⏩ 3 skipped benchmarks1
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
162.1 µs | 198.5 µs | -18.35% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
274 µs | 308.5 µs | -11.2% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
214.7 µs | 176.5 µs | +21.69% |
| ⚡ | Simulation | chunked_varbinview_opt_into_canonical[(1000, 10)] |
230.1 µs | 192.7 µs | +19.37% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
215.3 ns | 186.1 ns | +15.67% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
275.6 ns | 246.4 ns | +11.84% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/skipnans (5b21a56) with develop (59cf59c)
Footnotes
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩