Skip to content

feat!: Add eslint 10 support for unimport of wxt#2295

Open
PatrykKuniczak wants to merge 5 commits into
wxt-dev:mainfrom
PatrykKuniczak:feat/add-eslint-10-unimport-support
Open

feat!: Add eslint 10 support for unimport of wxt#2295
PatrykKuniczak wants to merge 5 commits into
wxt-dev:mainfrom
PatrykKuniczak:feat/add-eslint-10-unimport-support

Conversation

@PatrykKuniczak

Copy link
Copy Markdown
Collaborator

Overview

Added version 10 of eslint to Eslintrc and ResolvedEslintrc types

Related with #1981

@netlify

netlify Bot commented Apr 24, 2026

Copy link
Copy Markdown

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 466965c
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/69f0c5e249dca000088800ed
😎 Deploy Preview https://deploy-preview-2295--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the pkg/wxt Includes changes to the `packages/wxt` directory label Apr 24, 2026
@pkg-pr-new

pkg-pr-new Bot commented Apr 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2295

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2295

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2295

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2295

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2295

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2295

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2295

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2295

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2295

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2295

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2295

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2295

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2295

wxt

npm i https://pkg.pr.new/wxt@2295

commit: 466965c

@codecov

codecov Bot commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.71%. Comparing base (e75e534) to head (466965c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2295      +/-   ##
==========================================
- Coverage   79.73%   79.71%   -0.03%     
==========================================
  Files         131      131              
  Lines        3804     3805       +1     
  Branches      861      862       +1     
==========================================
  Hits         3033     3033              
- Misses        686      687       +1     
  Partials       85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/wxt/src/types.ts Outdated
@PatrykKuniczak

Copy link
Copy Markdown
Collaborator Author

@aklinker1 Should be good right now :)

@aklinker1

Copy link
Copy Markdown
Member

This PR is a breaking change as it stands now.

I'm not going to merge it, we're making way to many breaking changes. Make it work for people who still use 8 and 9 literals.

@PatrykKuniczak

Copy link
Copy Markdown
Collaborator Author

@aklinker1 Ok, i'll do a fallback and use @deprecated docs.

@PatrykKuniczak PatrykKuniczak changed the title feat: Add eslint 10 support for unimport of wxt feat!: Add eslint 10 support for unimport of wxt Jun 29, 2026
@PatrykKuniczak

Copy link
Copy Markdown
Collaborator Author

@aklinker1 I've rethough and rereview it, and i won't adjust it, because it can go to major with #2296

Let's wait with those(3) PRs on that topic, till you'll be releasing next major.

It isn't that big breaking changes, ok yeah, user need to change params, but that's it.
#2296 it bigger thing and i think both of those PRs should go in one release and that'll have the biggest sense and impact.

I want to suggest to do it in that way.

@aklinker1

aklinker1 commented Jun 29, 2026

Copy link
Copy Markdown
Member

No, this does not require a breaking change. We cannot have a release with as many breaking changes as this upcoming one ever again. I was too lax about this, and I don't think it will go over well with developers.

Deprecate the options and continue to support them. We can remove them in the major version after this one.

Removing deprecated APIs has a much smaller overhead for devs compared to hard cutting to a new behavior - people get warnings and can see the migration steps and take them ahead of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/wxt Includes changes to the `packages/wxt` directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants