blockifier,apollo_batcher: produce OS initial reads behind os_input by yoavGrs · Pull Request #14592 · starkware-libs/sequencer

yoavGrs · 2026-06-22T11:56:36Z

Add an os_input feature on blockifier and, behind it, compute the pre-block OS read values (CachedState::get_os_initial_reads) in finalize_block, expose them on BlockExecutionSummary/BlockExecutionArtifacts, and carry them into the batcher's CentralObjects decision-reached response. Not yet consumed downstream.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

reviewable-StarkWare · 2026-06-22T11:56:46Z

This change is

yoavGrs · 2026-06-22T11:56:53Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-06-22T11:57:02Z

Artifacts upload workflows:

cursor · 2026-06-22T11:57:33Z

PR Summary

Medium Risk
Changes block-close state extraction and enlarges consensus-facing payloads, but behavior is feature-gated and initial_reads is not yet used by downstream OS consumers.

Overview
Behind a new blockifier os_input feature (wired through apollo_batcher and CI), block finalization now builds pre-block StateMaps for Starknet OS replay via CachedState::get_os_initial_reads, which back-fills write-only storage, force-reads contract/class trie leaves, and drops declared_contracts.

Those values are attached to BlockExecutionSummary, carried in BlockExecutionArtifacts, and returned on CentralObjects.initial_reads in the decision_reached response alongside existing accessed_keys. Nothing downstream consumes initial_reads yet.

^{Reviewed by Cursor Bugbot for commit 6df9efa. Bugbot is set up for automated code reviews on this repo. Configure here.}

itamar-starkware

There is one comment about the feature flag removal. Consider split to more PRs to handle this design issue.

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit c52efb3. Configure here.}

cursor · 2026-06-23T07:23:30Z

    let state_diff = block_state.to_state_diff()?.state_maps;

+    #[cfg(feature = "os_input")]
+    let initial_reads = block_state.get_os_initial_reads()?;


Migration breaks OS initial reads

High Severity

get_os_initial_reads runs after set_compiled_class_hash_migration, so migrated classes already have post-migration compiled class hashes in the write cache. The OS backfill via get_compiled_class_hash then skips reading parent state and often leaves no pre-block compiled class hash in initial_reads, so downstream OS replay can get wrong trie inputs.

Additional Locations (1)

crates/blockifier/src/state/cached_state.rs#L301-L315

^{Reviewed by Cursor Bugbot for commit c52efb3. Configure here.}

It already inserts into the initial reads. See the discussion here:
https://reviewable.io/reviews/starkware-libs/sequencer/14612

yoavGrs

@yoavGrs made 1 comment.
Reviewable status: 0 of 10 files reviewed, 3 unresolved discussions (waiting on itamar-starkware).

Add an os_input feature on blockifier and, behind it, compute the pre-block OS read values (CachedState::get_os_initial_reads) in finalize_block, expose them on BlockExecutionSummary/BlockExecutionArtifacts, and carry them into the batcher's CentralObjects decision-reached response. Not yet consumed downstream. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

yoavGrs

@yoavGrs made 1 comment.
Reviewable status: 0 of 10 files reviewed, 2 unresolved discussions (waiting on itamar-starkware).

yoavGrs · 2026-06-23T18:34:08Z

    let state_diff = block_state.to_state_diff()?.state_maps;

+    #[cfg(feature = "os_input")]
+    let initial_reads = block_state.get_os_initial_reads()?;


It already inserts into the initial reads. See the discussion here:
https://reviewable.io/reviews/starkware-libs/sequencer/14612

This was referenced Jun 22, 2026

apollo_consensus_orchestrator: forward OS initial reads into the cende blob #14593

Open

starknet_os_flow_tests: build OS initial reads via get_os_initial_reads #14594

Open

blockifier,apollo_batcher: trim OS initial reads to the accessed-key set #14595

Open

yoavGrs marked this pull request as ready for review June 22, 2026 11:57

cursor Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread crates/apollo_batcher/src/block_builder_test.rs

yoavGrs force-pushed the yoav/os-initial-reads-1-produce branch from 2eba218 to 94cf5bb Compare June 22, 2026 14:02

yoavGrs assigned itamar-starkware and yoavGrs and unassigned itamar-starkware Jun 22, 2026

yoavGrs requested a review from itamar-starkware June 22, 2026 14:42

itamar-starkware requested changes Jun 23, 2026

View reviewed changes

Comment thread crates/blockifier/src/state/cached_state.rs

yoavGrs force-pushed the yoav/os-initial-reads-1-produce branch from 94cf5bb to c52efb3 Compare June 23, 2026 07:21

cursor Bot reviewed Jun 23, 2026

View reviewed changes

yoavGrs commented Jun 23, 2026

View reviewed changes

Comment thread crates/blockifier/src/state/cached_state.rs

yoavGrs force-pushed the yoav/os-initial-reads-1-produce branch from c52efb3 to 15affd5 Compare June 23, 2026 08:56

yoavGrs changed the base branch from main to graphite-base/14592 June 23, 2026 13:30

yoavGrs force-pushed the yoav/os-initial-reads-1-produce branch from 15affd5 to f5749a5 Compare June 23, 2026 13:31

yoavGrs changed the base branch from graphite-base/14592 to yoav/migration-initial-reads-fix June 23, 2026 13:31

yoavGrs mentioned this pull request Jun 23, 2026

blockifier: record pre-migration compiled class hash as initial read #14612

Closed

yoavGrs force-pushed the yoav/migration-initial-reads-fix branch from 94279be to cdbf3ab Compare June 23, 2026 14:42

yoavGrs force-pushed the yoav/os-initial-reads-1-produce branch from f5749a5 to 9f42919 Compare June 23, 2026 14:42

yoavGrs changed the base branch from yoav/migration-initial-reads-fix to graphite-base/14592 June 23, 2026 18:32

yoavGrs force-pushed the graphite-base/14592 branch from cdbf3ab to 01f17ad Compare June 23, 2026 18:32

yoavGrs force-pushed the yoav/os-initial-reads-1-produce branch from 9f42919 to 6df9efa Compare June 23, 2026 18:32

yoavGrs changed the base branch from graphite-base/14592 to main June 23, 2026 18:32

yoavGrs commented Jun 23, 2026

View reviewed changes

Conversation

yoavGrs commented Jun 22, 2026

Uh oh!

reviewable-StarkWare commented Jun 22, 2026

Uh oh!

yoavGrs commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

itamar-starkware left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Jun 23, 2026

Choose a reason for hiding this comment

Migration breaks OS initial reads

Uh oh!

yoavGrs Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yoavGrs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yoavGrs left a comment

Choose a reason for hiding this comment

Uh oh!

yoavGrs Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yoavGrs commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading

cursor Bot commented Jun 22, 2026 •

edited

Loading