Skip to content

starknet_os_flow_tests: build OS initial reads via get_os_initial_reads#14594

Merged
yoavGrs merged 1 commit into
mainfrom
yoav/os-initial-reads-3-flow-tests
Jun 24, 2026
Merged

starknet_os_flow_tests: build OS initial reads via get_os_initial_reads#14594
yoavGrs merged 1 commit into
mainfrom
yoav/os-initial-reads-3-flow-tests

Conversation

@yoavGrs

@yoavGrs yoavGrs commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Enable blockifier/os_input for the flow tests and replace the local get_extended_initial_reads helper with CachedState::get_os_initial_reads, so the tests build the OS initial reads exactly as production does.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

yoavGrs commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

@cursor

cursor Bot commented Jun 22, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only refactor in integration tests; behavior should match production more closely via the shared blockifier API.

Overview
Starknet OS flow tests now build block initial reads the same way the batcher/executor does, instead of a crate-local helper.

The blockifier dev-dependency gains the os_input feature so tests can call CachedState::get_os_initial_reads. In test_manager, both places that fed OsBlockInput / decompression (per-block build and full-run TestRunner::run) switch from get_extended_initial_reads to that API. The duplicated get_extended_initial_reads implementation is removed from utils.rs (and the unused StateMaps import there).

This keeps integration tests aligned with production OS initial-read construction (including write-only access back-fill in blockifier), with no production code changes.

Reviewed by Cursor Bugbot for commit d493b74. Bugbot is set up for automated code reviews on this repo. Configure here.

@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-2-cende-blob branch from 01ca36b to 2c07dbb Compare June 22, 2026 14:02
@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-3-flow-tests branch from f4a9965 to 94b61d9 Compare June 22, 2026 14:02
@yoavGrs yoavGrs self-assigned this Jun 22, 2026
@yoavGrs yoavGrs requested a review from itamar-starkware June 22, 2026 14:43
@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-2-cende-blob branch from 2c07dbb to 22efea3 Compare June 23, 2026 07:21
@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-3-flow-tests branch from 94b61d9 to 4cc1677 Compare June 23, 2026 07:21
@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-2-cende-blob branch from 22efea3 to ce473eb Compare June 23, 2026 08:56
@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-3-flow-tests branch from 4cc1677 to 5410333 Compare June 23, 2026 08:56
@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-3-flow-tests branch from 5410333 to 9d4eabf Compare June 23, 2026 13:31
@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-2-cende-blob branch from ce473eb to 02a352d Compare June 23, 2026 13:31
@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-3-flow-tests branch from 9d4eabf to d57b5a2 Compare June 23, 2026 14:42
@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-2-cende-blob branch 2 times, most recently from eec217d to f8ff834 Compare June 23, 2026 18:32
@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-3-flow-tests branch from d57b5a2 to 9863839 Compare June 23, 2026 18:32

@itamar-starkware itamar-starkware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itamar-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-3-flow-tests branch from 9863839 to 3f9bc02 Compare June 24, 2026 08:26
@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-2-cende-blob branch 2 times, most recently from 31b3b1c to bd730c1 Compare June 24, 2026 08:57
@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-3-flow-tests branch 2 times, most recently from af1d0d4 to e1f8308 Compare June 24, 2026 09:07
@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-2-cende-blob branch from bd730c1 to 85c6177 Compare June 24, 2026 09:07
Enable blockifier/os_input for the flow tests and replace the local get_extended_initial_reads helper with CachedState::get_os_initial_reads, so the tests build the OS initial reads exactly as production does.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@yoavGrs yoavGrs changed the base branch from yoav/os-initial-reads-2-cende-blob to graphite-base/14594 June 24, 2026 09:54
@yoavGrs yoavGrs force-pushed the yoav/os-initial-reads-3-flow-tests branch from e1f8308 to d493b74 Compare June 24, 2026 09:54
@yoavGrs yoavGrs force-pushed the graphite-base/14594 branch from 85c6177 to c5b7e32 Compare June 24, 2026 09:54
@yoavGrs yoavGrs changed the base branch from graphite-base/14594 to main June 24, 2026 09:54
@yoavGrs yoavGrs added this pull request to the merge queue Jun 24, 2026
Merged via the queue into main with commit a3a16c7 Jun 24, 2026
26 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants