blockifier,apollo_batcher: trim OS initial reads to the accessed-key set#14595
Conversation
PR SummaryMedium Risk Overview
In OS flow tests apply the same trim before assembling block OS input, matching production and exercising reverted-tx cases. A small committer comment clarifies the Reviewed by Cursor Bugbot for commit ba1162c. Bugbot is set up for automated code reviews on this repo. Configure here. |
baca9cc to
c0904c6
Compare
f4a9965 to
94b61d9
Compare
c0904c6 to
28dc2c0
Compare
94b61d9 to
4cc1677
Compare
28dc2c0 to
840c728
Compare
4cc1677 to
5410333
Compare
|
Suggestion from Claude Code: Could we add direct unit tests in
|
840c728 to
41b34a9
Compare
41b34a9 to
f334583
Compare
5410333 to
9d4eabf
Compare
9d4eabf to
d57b5a2
Compare
f334583 to
c7678fc
Compare
d57b5a2 to
9863839
Compare
c7678fc to
d865f09
Compare
itamar-starkware
left a comment
There was a problem hiding this comment.
@itamar-starkware reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
d865f09 to
89077d2
Compare
9863839 to
3f9bc02
Compare
89077d2 to
f85eb08
Compare
3f9bc02 to
af1d0d4
Compare
f85eb08 to
32d8ff2
Compare
e1f8308 to
d493b74
Compare
32d8ff2 to
eeea13b
Compare
d493b74 to
a3a16c7
Compare
eeea13b to
ec51fe6
Compare
Drop initial-reads entries whose keys are not in AccessedKeys (e.g. storage cells read only by a reverted transaction). The OS replays from the read values of the keys it accesses and needs nothing beyond that set, so the extra entries would only bloat the cende blob. Validated by the OS flow tests (113 passing), including all reverted-tx cases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ec51fe6 to
ba1162c
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
|
Security scan complete — no issues detected. Generated by Claude Code |

Drop initial-reads entries whose keys are not in AccessedKeys (e.g. storage cells read only by a reverted transaction). The OS replays from the read values of the keys it accesses and needs nothing beyond that set, so the extra entries would only bloat the cende blob. Validated by the OS flow tests (113 passing), including all reverted-tx cases.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com