TS strict (2/4): strictNullChecks null-safety guards#3687
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Because this PR doesn't target main, I don't think TS and such ran. How about merging the base (1/4) to main since it's safe and ready, then this one could target main and the TS checks will run again. |
tegan-temporal
force-pushed
the
strict/1-base
branch
from
July 17, 2026 16:46
1b28a4f to
4c59793
Compare
tegan-temporal
force-pushed
the
strict/2-mechanical
branch
from
July 17, 2026 16:46
81d60a7 to
71501db
Compare
tegan-temporal
marked this pull request as ready for review
July 17, 2026 17:00
Contributor
|
tegan-temporal
commented
Jul 17, 2026
| } | ||
|
|
||
| $form.specs = [...$form.specs, { kind: 'cron', cronString: '' }]; | ||
| $form.specs = [...$form.specs, getFormSpecInitialData('cron')]; |
Contributor
Author
There was a problem hiding this comment.
this change was necessary because { kind: 'cron', cronString: '' } is incomplete, getFormSpecInitialData gives us the full shape.
Mechanical null-safety: nullish-coalescing defaults, optional chaining,
{#if} render guards, and generics-driven refactors. Behavior-preserving.
Rebased onto main after the base PR (#3686) merged.
tegan-temporal
force-pushed
the
strict/2-mechanical
branch
from
July 17, 2026 17:36
c4adac5 to
8e9e26e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of a 4-PR split of #3640. Stacked on
strict/1-base.Mechanical null-safety introduced by strictNullChecks: nullish-coalescing defaults (
?? '',?? 0,?? []), optional chaining,{#if}render guards, and a few generics-driven refactors. Intended to be behavior-preserving — no server-request or form-default semantics change (those are in 3/4). 189 files, verified strict-clean against the base PR.Stack (merge bottom-up):
strict/1-base— type annotations + CI infra (zero runtime)strict/2-mechanical— strictNullChecks null-safety guardsstrict/3-behavior— runtime-affecting model/form/service changests-strict-mode(TS strict (4/4): enable strict mode in base tsconfig #3640) — flipstrict: trueOriginal combined branch preserved in #3640, now reduced to the final flag flip. Split verified: stacking all four reproduces the original tree byte-for-byte.