apollo_integration_tests,apollo_node_config: load integration-test node config via native format

[nimrod-starkware]

Make the integration-test harness emit a nested native config artifact plus a
secrets file and boot the node with --config_format native (two --config_file
paths: nested base first, flat secrets second), instead of the legacy preset
single-file path. Adds as_native_value/dump_native_config_file alongside the
retained preset as_value, a {} secrets file, and node_config_paths() returning
[base, secrets]; both spawn_run_node call sites pass the two-file vector.

This is the prerequisite that lets the integration suite exercise the native
load path before the preset path is torn down.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

[nimrod-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• deployment: drop redundant YAML sequencerConfig; source port-uniqueness from jsonnet #14659
• apollo_config,workspace: remove SerializeConfig trait and preset-dump machinery #14654
• apollo_config,apollo_node_config,apollo_config_manager: rework get_config_presentation off dump() #14653
• apollo_node_config,apollo_node: delete CONFIG_POINTERS data and pointer-remap from secrets bin #14652
• apollo_node_config,apollo_config_manager,apollo_integration_tests: retire preset config-generation path #14651
• apollo_node_config,apollo_deployments: assert cross-component equality for formerly-pointer-resolved fields #14650
• apollo_deployments: delete base app_configs and the preset-parity test machinery #14649
• apollo_node_config,apollo_node,deployment: source private_parameters from secrets schema, drop value config schema #14648
• apollo_deployments: retire dead preset/replacer generation machinery #14647
• deployment,apollo_deployments: drop config_format plumbing and retire preset config path #14646
• deployment: add native config layers for the testing overlays #14645
• deployment: add dummy_for_testing native config override layer #14632
• apollo_config: make native the sole config-load path #14631
• apollo_config,apollo_node_config: make config fields with custom deserializers serialize symmetrically #14630
• apollo_integration_tests,apollo_node_config: load integration-test node config via native format #14629 👈 (View in Graphite)
• deployment: add mainnet native config override layer #14628
• deployment: add sepolia-alpha native config override layer #14627
• apollo_deployments: test overrides list match #14626
• deployment,ci: add hybrid native override layers and their validation tests #14610
• deployment: add hybrid common native override layer + lockstep test #14655
• deployment: add native node-config builder and wire it into the ConfigMap #14609
• deployment: thread config_format from CLI to node container arg #14608
• apollo_deployments,deployment: set storage-reader-server ports as constants #14607
• apollo_node: add new CLI arg to parse config #14606
• apollo_deployments: check applicative config matches deployed app_configs #14489 : 2 other dependent PRs (#14480 , #14505 )
• apollo_deployments: assemble and deserialize node config from jsonnet #14487
• apollo_deployments: assemble full node config via build.libsonnet #14486
• apollo_deployments: distributed layout jsonnet test #14485
• apollo_deployments: consolidated layout jsonnet test #14484
• apollo_deployments: test hybrid layout for infra config #14483
• apollo_deployments: introduce hybrid layout for infra config #14482
• apollo_deployments: introduce jsonnet building blocks for infra config #14481
• apollo_deployments: jsonnet applicative config #14479
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

@nimrod-starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion.

---

crates/apollo_integration_tests/src/executable_setup.rs line 109 at r1 (raw file):

    /// Config files passed to the native loader, base first then secrets, matching the
    /// `[base, secret]` arity expected by `load_native`.
    pub fn node_config_paths(&self) -> Vec<PathBuf> {

Suggestion:

 pub(crate) fn node_config_paths(&self) -> [PathBuf; 2] {

[cursor]

PR Summary

Medium Risk
Test-only change, but native dumps serialize SequencerNodeConfig directly while preset dumps applied pointer maps—integration coverage could diverge from preset behavior until preset is removed.

Overview
Integration tests now exercise the same native config load path as production deployments instead of the legacy preset single-file loader.

The harness writes a nested base JSON (dump_native_config_file / as_native_value) plus a second flat secrets file ({} when tests have no secrets), and starts apollo_node with --config_format native and two --config_file arguments (base, then secrets). ExecutableSetup exposes node_config_paths() for that pair; both spawn_run_node call sites use it. Preset helpers (as_value / dump_config_file) remain for other callers.

DeploymentBaseAppConfig gains native serialization alongside the unchanged preset pipeline, which still applies pointer maps and flat preset shaping—only the integration artifact format switched.

^{Reviewed by Cursor Bugbot for commit 0797ffc. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 0797ffc. Configure here.}

[cursor]

Native dump skips pointer map

Medium Severity

as_native_value serializes only self.config, while as_value merges config_pointers_map via combine_config_map_and_pointers. The native loader does not resolve pointers, so booted nodes can see different values (e.g. shared recorder_url, native_classes_whitelist) than under the previous preset file path, including after modify_config_pointers without matching struct updates.

Additional Locations (1)

• crates/apollo_integration_tests/src/executable_setup.rs#L89-L135

 

^{Reviewed by Cursor Bugbot for commit 0797ffc. Configure here.}