apollo_config: make native the sole config-load path#14631
Draft
nimrod-starkware wants to merge 1 commit into
Draft
apollo_config: make native the sole config-load path#14631nimrod-starkware wants to merge 1 commit into
nimrod-starkware wants to merge 1 commit into
Conversation
This was referenced Jun 25, 2026
This was referenced Jun 25, 2026
Contributor
Author
This was referenced Jun 25, 2026
22984a6 to
407157e
Compare
d8e24ea to
06da659
Compare
This was referenced Jun 28, 2026
Draft
06da659 to
5eb5701
Compare
407157e to
9b677ae
Compare
5eb5701 to
ec5b1f7
Compare
9b677ae to
de0822e
Compare
Delete the preset branch of load_and_process_config so load_native is the only loader: remove the ConfigFormat enum + --config_format arg, the per-param CLI override parser (build_args_parser/update_config_map_by_command_args), the load-time config_schema.json read, the pointer-resolution and #is_none-folding functions (split_pointers_map, split_values_and_types, update_config_map_by_pointers, update_optional_values), and the config_parity dev bin. Callers stop passing --config_format. Pointer/#is_none DEFINITIONS, CONFIG_POINTERS, dump()/SerializeConfig, and CONFIG_SCHEMA_PATH are retained for later phases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
de0822e to
e752ded
Compare
ec5b1f7 to
ff18571
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Delete the preset branch of load_and_process_config so load_native is the only
loader: remove the ConfigFormat enum + --config_format arg, the per-param CLI
override parser (build_args_parser/update_config_map_by_command_args), the
load-time config_schema.json read, the pointer-resolution and #is_none-folding
functions (split_pointers_map, split_values_and_types,
update_config_map_by_pointers, update_optional_values), and the config_parity
dev bin. Callers stop passing --config_format. Pointer/#is_none DEFINITIONS,
CONFIG_POINTERS, dump()/SerializeConfig, and CONFIG_SCHEMA_PATH are retained for
later phases.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com