deployment: drop redundant YAML sequencerConfig; source port-uniqueness from jsonnet#14659
Draft
nimrod-starkware wants to merge 1 commit into
Draft
Conversation
…ss from jsonnet The cdk8s ConfigMap is built solely from the jsonnet override layers (build_native_config); the YAML config.sequencerConfig blocks are now redundant duplicate data. Delete them from every public hybrid overlay YAML (the env-specific values — chain_id, recorder_url, cache_size, fee tokens, ports — all live in the sequencer_config.jsonnet layers). Delete the lockstep parity tests that compared jsonnet to YAML (their YAML side is gone) and migrate test_port_uniqueness's within-service and cross-service component-port checks to read the built native config instead of YAML sequencerConfig, filtering port==0 (disabled components) and gaining coverage of the storage-reader/subsystem ports the YAML never enumerated. The schema.py sequencerConfig field and merger.py merge branch are deliberately kept: StrictBaseModel uses extra=forbid, so the loader must still accept devops-repo overlays that carry sequencerConfig until that out-of-repo cleanup lands. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This change is |
This was referenced Jun 28, 2026
Open
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cdk8s ConfigMap is built solely from the jsonnet override layers (build_native_config); the YAML config.sequencerConfig blocks are now redundant duplicate data. Delete them from every public hybrid overlay YAML (the env-specific values — chain_id, recorder_url, cache_size, fee tokens, ports — all live in the sequencer_config.jsonnet layers). Delete the lockstep parity tests that compared jsonnet to YAML (their YAML side is gone) and migrate test_port_uniqueness's within-service and cross-service component-port checks to read the built native config instead of YAML sequencerConfig, filtering port==0 (disabled components) and gaining coverage of the storage-reader/subsystem ports the YAML never enumerated. The schema.py sequencerConfig field and merger.py merge branch are deliberately kept: StrictBaseModel uses extra=forbid, so the loader must still accept devops-repo overlays that carry sequencerConfig until that out-of-repo cleanup lands.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com