apollo_node_config,apollo_node,deployment: source private_parameters from secrets schema, drop value config schema#14648
Draft
nimrod-starkware wants to merge 1 commit into
Conversation
This was referenced Jun 28, 2026
This was referenced Jun 28, 2026
Open
Contributor
Author
This was referenced Jun 28, 2026
89ab258 to
c0351e0
Compare
84755fc to
3c4b392
Compare
3c4b392 to
dbff560
Compare
…from secrets schema, drop value config schema private_parameters() now reads the committed config_secrets_schema.json (a BTreeSet of ParamPath) instead of deriving from config_schema.json + CONFIG_POINTERS at runtime, removing the runtime dependency on both. Delete the value config_schema.json (4147 lines) and the CONFIG_SCHEMA_PATH const (the native loader never read it; the per-param CLI parser that did is gone), and remove its now-broken COPY from the sequencer Dockerfile. Repurpose update_apollo_node_config_schema to regenerate ONLY the secrets schema, and split the up-to-date guard to assert only the secrets schema. A transient equivalence test (private_parameters_matches_config_dump_derivation) proves the file-sourced set equals the old dump()+CONFIG_POINTERS derivation (no drift); it is marked for removal with the later SerializeConfig/CONFIG_POINTERS teardown. config_secrets_schema.json regenerates byte-identical; apollo_node_config 30/30 and apollo_deployments 9/9 green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
4f5f772 to
ece79f9
Compare
dbff560 to
16c545d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

private_parameters() now reads the committed config_secrets_schema.json (a BTreeSet of
ParamPath) instead of deriving from config_schema.json + CONFIG_POINTERS at runtime,
removing the runtime dependency on both. Delete the value config_schema.json (4147 lines)
and the CONFIG_SCHEMA_PATH const (the native loader never read it; the per-param CLI
parser that did is gone), and remove its now-broken COPY from the sequencer Dockerfile.
Repurpose update_apollo_node_config_schema to regenerate ONLY the secrets schema, and
split the up-to-date guard to assert only the secrets schema. A transient equivalence test
(private_parameters_matches_config_dump_derivation) proves the file-sourced set equals the
old dump()+CONFIG_POINTERS derivation (no drift); it is marked for removal with the later
SerializeConfig/CONFIG_POINTERS teardown.
config_secrets_schema.json regenerates byte-identical; apollo_node_config 30/30 and
apollo_deployments 9/9 green.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com