Skip to content

apollo_node_config,apollo_node,deployment: source private_parameters from secrets schema, drop value config schema#14648

Draft
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/retire-replacer-generationfrom
nimrod/jsonnet/source-private-params-from-secrets-schema
Draft

apollo_node_config,apollo_node,deployment: source private_parameters from secrets schema, drop value config schema#14648
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/retire-replacer-generationfrom
nimrod/jsonnet/source-private-params-from-secrets-schema

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

private_parameters() now reads the committed config_secrets_schema.json (a BTreeSet of
ParamPath) instead of deriving from config_schema.json + CONFIG_POINTERS at runtime,
removing the runtime dependency on both. Delete the value config_schema.json (4147 lines)
and the CONFIG_SCHEMA_PATH const (the native loader never read it; the per-param CLI
parser that did is gone), and remove its now-broken COPY from the sequencer Dockerfile.
Repurpose update_apollo_node_config_schema to regenerate ONLY the secrets schema, and
split the up-to-date guard to assert only the secrets schema. A transient equivalence test
(private_parameters_matches_config_dump_derivation) proves the file-sourced set equals the
old dump()+CONFIG_POINTERS derivation (no drift); it is marked for removal with the later
SerializeConfig/CONFIG_POINTERS teardown.

config_secrets_schema.json regenerates byte-identical; apollo_node_config 30/30 and
apollo_deployments 9/9 green.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

…from secrets schema, drop value config schema

private_parameters() now reads the committed config_secrets_schema.json (a BTreeSet of
ParamPath) instead of deriving from config_schema.json + CONFIG_POINTERS at runtime,
removing the runtime dependency on both. Delete the value config_schema.json (4147 lines)
and the CONFIG_SCHEMA_PATH const (the native loader never read it; the per-param CLI
parser that did is gone), and remove its now-broken COPY from the sequencer Dockerfile.
Repurpose update_apollo_node_config_schema to regenerate ONLY the secrets schema, and
split the up-to-date guard to assert only the secrets schema. A transient equivalence test
(private_parameters_matches_config_dump_derivation) proves the file-sourced set equals the
old dump()+CONFIG_POINTERS derivation (no drift); it is marked for removal with the later
SerializeConfig/CONFIG_POINTERS teardown.

config_secrets_schema.json regenerates byte-identical; apollo_node_config 30/30 and
apollo_deployments 9/9 green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 4f5f772 to ece79f9 Compare June 28, 2026 14:04
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from dbff560 to 16c545d Compare June 28, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants