apollo_config,apollo_node_config,apollo_config_manager: rework get_config_presentation off dump()#14653
Draft
nimrod-starkware wants to merge 1 commit into
Conversation
This was referenced Jun 28, 2026
Draft
Contributor
Author
This was referenced Jun 28, 2026
452bc9e to
98aaff6
Compare
7503a2b to
102de97
Compare
102de97 to
11caafd
Compare
98aaff6 to
198918e
Compare
…nfig_presentation off dump() get_config_presentation was the last native-path consumer of dump() (it used dump() only as a privacy registry to redact Private params from the startup-log / config-diff presentation). Rework it to take an injected private-path set: get_config_presentation<T: Serialize>(config, include_private_parameters, private_paths) — dropping the SerializeConfig bound. Callers (load_and_validate_config startup log, config_manager diff) inject &private_parameters() (the committed config_secrets_schema.json set). The injected set equals the old dump()-derived Private set exactly (is_private() == privacy==Private), so redaction is preserved with no leak / no over-redaction; a new no-leak test guards it. remove_path_from_json (the redaction mechanism) is retained. This unblocks deleting dump()/SerializeConfig in Phase 9. apollo_config 27+4, apollo_config_manager 15, apollo_node_config 33, apollo_deployments 8 green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
198918e to
853a39d
Compare
11caafd to
3096831
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

get_config_presentation was the last native-path consumer of dump() (it used dump() only
as a privacy registry to redact Private params from the startup-log / config-diff
presentation). Rework it to take an injected private-path set:
get_config_presentation<T: Serialize>(config, include_private_parameters, private_paths)
— dropping the SerializeConfig bound. Callers (load_and_validate_config startup log,
config_manager diff) inject &private_parameters() (the committed config_secrets_schema.json
set). The injected set equals the old dump()-derived Private set exactly (is_private() ==
privacy==Private), so redaction is preserved with no leak / no over-redaction; a new
no-leak test guards it. remove_path_from_json (the redaction mechanism) is retained.
This unblocks deleting dump()/SerializeConfig in Phase 9. apollo_config 27+4,
apollo_config_manager 15, apollo_node_config 33, apollo_deployments 8 green.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com