Skip to content

deployment: add hybrid common native override layer + lockstep test#14655

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/native-config-builderfrom
nimrod/jsonnet/native-override-common
Open

deployment: add hybrid common native override layer + lockstep test#14655
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/native-config-builderfrom
nimrod/jsonnet/native-override-common

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Add the base (common) hybrid sequencer_config.jsonnet override layer consumed by the native config builder, plus the durable per-layer regression test that keeps it in lockstep with the YAML overlays: the common layer's jsonnet, flattened to dotted keys, must exactly match the combined config.sequencerConfig of the common-layer YAMLs (with #is_none folded and components.* dropped). This prevents the native and preset generation paths from silently drifting.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Add the base (common) hybrid sequencer_config.jsonnet override layer consumed by the native config builder, plus the durable per-layer regression test that keeps it in lockstep with the YAML overlays: the common layer's jsonnet, flattened to dotted keys, must exactly match the combined config.sequencerConfig of the common-layer YAMLs (with #is_none folded and components.* dropped). This prevents the native and preset generation paths from silently drifting.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware nimrod-starkware self-assigned this Jun 28, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review June 28, 2026 12:06
@cursor

cursor Bot commented Jun 28, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Deployment overlay and test-only changes; no runtime application logic, though incorrect values could misconfigure sequencers if merged configs are wrong.

Overview
Introduces the hybrid common sequencer_config.jsonnet override layer used by the native node-config builder, encoding env-independent sequencer settings (fee tokens, ports, consensus/gateway/mempool limits, etc.) as nested JSON instead of flat YAML overlays.

Adds a lockstep regression test that evaluates that jsonnet, flattens it to dotted keys, and requires an exact match with the combined config.sequencerConfig from the common-layer YAMLs after folding #is_none markers and dropping components.*, so the native and preset config paths cannot drift silently.

Reviewed by Cursor Bugbot for commit 03b48d4. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants