apollo_deployments: delete base app_configs and the preset-parity test machinery#14649
Draft
nimrod-starkware wants to merge 1 commit into
Conversation
This was referenced Jun 28, 2026
Draft
Contributor
Author
This was referenced Jun 28, 2026
a4eefa9 to
ec8f72b
Compare
3c4b392 to
dbff560
Compare
ec8f72b to
9ecf4fe
Compare
…t machinery
jsonnet build() is the sole source of the node config, so the committed base
app_configs/*_config.json and the build()-vs-app_configs parity test are dead.
Delete the 21 base *_config.json, merged_app_configs/non_default_paths/
test_applicative_matches_app_configs and the applicative_matches_app_configs test,
plus their last-user constants KEYS_TO_BE_REPLACED and BASE_APP_CONFIGS_DIR_PATH
(and the now-dead get_component_config_{names,file_paths}), and drop the freed phf
dep. Keep CONFIG_POINTERS/dump()/config_to_preset definitions and the
build_*_deserializes + *_infra_matches_rust guards (later phases own those).
apollo_deployments 8/8 green; cdk8s synth 31/31 green (build() sole source).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
9ecf4fe to
e84d1fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

jsonnet build() is the sole source of the node config, so the committed base
app_configs/config.json and the build()-vs-app_configs parity test are dead.
Delete the 21 base *config.json, merged_app_configs/non_default_paths/
test_applicative_matches_app_configs and the applicative_matches_app_configs test,
plus their last-user constants KEYS_TO_BE_REPLACED and BASE_APP_CONFIGS_DIR_PATH
(and the now-dead get_component_config{names,file_paths}), and drop the freed phf
dep. Keep CONFIG_POINTERS/dump()/config_to_preset definitions and the
build_deserializes + *_infra_matches_rust guards (later phases own those).
apollo_deployments 8/8 green; cdk8s synth 31/31 green (build() sole source).
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com