Skip to content

apollo_node_config,apollo_config_manager,apollo_integration_tests: retire preset config-generation path#14651

Draft
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/validate-cross-component-equalityfrom
nimrod/jsonnet/retire-preset-config-generation
Draft

apollo_node_config,apollo_config_manager,apollo_integration_tests: retire preset config-generation path#14651
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/validate-cross-component-equalityfrom
nimrod/jsonnet/retire-preset-config-generation

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Delete the flat-preset config generation now that everything loads native: remove
ConfigPointersMap and DeploymentBaseAppConfig::{as_value, dump_config_file,
config_pointers_map, get/modify_config_pointers, validate_all_pointer_targets_set}.
Migrate the integration-test setup and config_manager_runner_tests off the pointer-
resolved as_value path to the native as_native_value path (the config_manager test was
already failing at HEAD: it passed a single --config_file but native load requires two).
Promote normalize_pointer_groups to a shared cfg(testing/test) helper in config_utils.
create_node_config now sets validator_id directly on the real struct (the native dump
ignored the pointer map).

This unblocks deleting CONFIG_POINTERS (its only remaining consumers are the secrets-schema
bin + the transient equivalence test). apollo_config_manager 15/15, apollo_node_config
34/34, apollo_deployments 8/8 green; integration bins compile.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

…tire preset config-generation path

Delete the flat-preset config generation now that everything loads native: remove
ConfigPointersMap and DeploymentBaseAppConfig::{as_value, dump_config_file,
config_pointers_map, get/modify_config_pointers, validate_all_pointer_targets_set}.
Migrate the integration-test setup and config_manager_runner_tests off the pointer-
resolved as_value path to the native as_native_value path (the config_manager test was
already failing at HEAD: it passed a single --config_file but native load requires two).
Promote normalize_pointer_groups to a shared cfg(testing/test) helper in config_utils.
create_node_config now sets validator_id directly on the real struct (the native dump
ignored the pointer map).

This unblocks deleting CONFIG_POINTERS (its only remaining consumers are the secrets-schema
bin + the transient equivalence test). apollo_config_manager 15/15, apollo_node_config
34/34, apollo_deployments 8/8 green; integration bins compile.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/validate-cross-component-equality branch from 614e204 to b42f836 Compare June 28, 2026 14:04
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-generation branch from c0d2f48 to 4e8c344 Compare June 28, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants