apollo_node_config,apollo_config_manager,apollo_integration_tests: retire preset config-generation path#14651
Draft
nimrod-starkware wants to merge 1 commit into
Conversation
This was referenced Jun 28, 2026
This was referenced Jun 28, 2026
Contributor
Author
This was referenced Jun 28, 2026
5257d79 to
e1fdf85
Compare
7644cf5 to
31be7f8
Compare
31be7f8 to
c0d2f48
Compare
…tire preset config-generation path
Delete the flat-preset config generation now that everything loads native: remove
ConfigPointersMap and DeploymentBaseAppConfig::{as_value, dump_config_file,
config_pointers_map, get/modify_config_pointers, validate_all_pointer_targets_set}.
Migrate the integration-test setup and config_manager_runner_tests off the pointer-
resolved as_value path to the native as_native_value path (the config_manager test was
already failing at HEAD: it passed a single --config_file but native load requires two).
Promote normalize_pointer_groups to a shared cfg(testing/test) helper in config_utils.
create_node_config now sets validator_id directly on the real struct (the native dump
ignored the pointer map).
This unblocks deleting CONFIG_POINTERS (its only remaining consumers are the secrets-schema
bin + the transient equivalence test). apollo_config_manager 15/15, apollo_node_config
34/34, apollo_deployments 8/8 green; integration bins compile.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
614e204 to
b42f836
Compare
c0d2f48 to
4e8c344
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Delete the flat-preset config generation now that everything loads native: remove
ConfigPointersMap and DeploymentBaseAppConfig::{as_value, dump_config_file,
config_pointers_map, get/modify_config_pointers, validate_all_pointer_targets_set}.
Migrate the integration-test setup and config_manager_runner_tests off the pointer-
resolved as_value path to the native as_native_value path (the config_manager test was
already failing at HEAD: it passed a single --config_file but native load requires two).
Promote normalize_pointer_groups to a shared cfg(testing/test) helper in config_utils.
create_node_config now sets validator_id directly on the real struct (the native dump
ignored the pointer map).
This unblocks deleting CONFIG_POINTERS (its only remaining consumers are the secrets-schema
bin + the transient equivalence test). apollo_config_manager 15/15, apollo_node_config
34/34, apollo_deployments 8/8 green; integration bins compile.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com