Skip to content

apollo_config,workspace: remove SerializeConfig trait and preset-dump machinery#14654

Draft
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/presentation-off-dumpfrom
nimrod/jsonnet/remove-serialize-config
Draft

apollo_config,workspace: remove SerializeConfig trait and preset-dump machinery#14654
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/presentation-off-dumpfrom
nimrod/jsonnet/remove-serialize-config

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Final teardown of the preset config path. The native loader is the sole
load path, so the dump()/SerializeConfig apparatus has no remaining
consumers.

  • Delete the SerializeConfig trait, dump()/dump_to_file(),
    combine_config_map_and_pointers, the ser_*/prepend_sub_config_name
    builders, and IS_NONE_MARK (apollo_config/src/dumping.rs deleted; lib.rs
    trimmed, keeping ParamPath/FIELD_SEPARATOR/SerializationType/ConfigError).
  • Delete all ~107 impl SerializeConfig blocks across ~50 crates.
  • Remove the SerializeConfig supertrait bound from StorageConfigTrait
    (trait kept) and the storage/committer config impls.
  • Delete config_to_preset/prune_by_is_none defs (config_utils.rs) and the
    orphaned inherent NativeClassesWhitelist::ser_param (blockifier).
  • Retire the update_apollo_node_config_schema bin: config_secrets_schema.json
    is now the hand-maintained source of truth (Option A). Replace the
    dump()-derived secrets guard with a type-based guard that serializes
    default() and asserts the Sensitive-redacted paths are a subset of the
    committed schema (documented gap: None-default secrets emit no sentinel).
  • config_secrets_schema.json is byte-unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@github-actions

github-actions Bot commented Jun 28, 2026

Copy link
Copy Markdown

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

… machinery

Final teardown of the preset config path. The native loader is the sole
load path, so the dump()/SerializeConfig apparatus has no remaining
consumers.

- Delete the SerializeConfig trait, dump()/dump_to_file(),
  combine_config_map_and_pointers, the ser_*/prepend_sub_config_name
  builders, and IS_NONE_MARK (apollo_config/src/dumping.rs deleted; lib.rs
  trimmed, keeping ParamPath/FIELD_SEPARATOR/SerializationType/ConfigError).
- Delete all ~107 impl SerializeConfig blocks across ~50 crates.
- Remove the SerializeConfig supertrait bound from StorageConfigTrait
  (trait kept) and the storage/committer config impls.
- Delete config_to_preset/prune_by_is_none defs (config_utils.rs) and the
  orphaned inherent NativeClassesWhitelist::ser_param (blockifier).
- Retire the update_apollo_node_config_schema bin: config_secrets_schema.json
  is now the hand-maintained source of truth (Option A). Replace the
  dump()-derived secrets guard with a type-based guard that serializes
  default() and asserts the Sensitive-redacted paths are a subset of the
  committed schema (documented gap: None-default secrets emit no sentinel).
- config_secrets_schema.json is byte-unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from 11caafd to 3096831 Compare June 28, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants