apollo_config,workspace: remove SerializeConfig trait and preset-dump machinery#14654
Draft
nimrod-starkware wants to merge 1 commit into
Draft
Conversation
|
Artifacts upload workflows: |
This was referenced Jun 28, 2026
Draft
Contributor
Author
This was referenced Jun 28, 2026
This was referenced Jun 28, 2026
cdced14 to
dbc39e5
Compare
dbc39e5 to
786854f
Compare
102de97 to
11caafd
Compare
… machinery Final teardown of the preset config path. The native loader is the sole load path, so the dump()/SerializeConfig apparatus has no remaining consumers. - Delete the SerializeConfig trait, dump()/dump_to_file(), combine_config_map_and_pointers, the ser_*/prepend_sub_config_name builders, and IS_NONE_MARK (apollo_config/src/dumping.rs deleted; lib.rs trimmed, keeping ParamPath/FIELD_SEPARATOR/SerializationType/ConfigError). - Delete all ~107 impl SerializeConfig blocks across ~50 crates. - Remove the SerializeConfig supertrait bound from StorageConfigTrait (trait kept) and the storage/committer config impls. - Delete config_to_preset/prune_by_is_none defs (config_utils.rs) and the orphaned inherent NativeClassesWhitelist::ser_param (blockifier). - Retire the update_apollo_node_config_schema bin: config_secrets_schema.json is now the hand-maintained source of truth (Option A). Replace the dump()-derived secrets guard with a type-based guard that serializes default() and asserts the Sensitive-redacted paths are a subset of the committed schema (documented gap: None-default secrets emit no sentinel). - config_secrets_schema.json is byte-unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
11caafd to
3096831
Compare
786854f to
318f298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Final teardown of the preset config path. The native loader is the sole
load path, so the dump()/SerializeConfig apparatus has no remaining
consumers.
combine_config_map_and_pointers, the ser_*/prepend_sub_config_name
builders, and IS_NONE_MARK (apollo_config/src/dumping.rs deleted; lib.rs
trimmed, keeping ParamPath/FIELD_SEPARATOR/SerializationType/ConfigError).
(trait kept) and the storage/committer config impls.
orphaned inherent NativeClassesWhitelist::ser_param (blockifier).
is now the hand-maintained source of truth (Option A). Replace the
dump()-derived secrets guard with a type-based guard that serializes
default() and asserts the Sensitive-redacted paths are a subset of the
committed schema (documented gap: None-default secrets emit no sentinel).
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com