apollo_deployments: retire dead preset/replacer generation machinery#14647
Draft
nimrod-starkware wants to merge 1 commit into
Draft
Conversation
This was referenced Jun 28, 2026
This was referenced Jun 28, 2026
Contributor
Author
This was referenced Jun 28, 2026
Draft
89ab258 to
c0351e0
Compare
0df4a4a to
a07b98f
Compare
a07b98f to
a3d7879
Compare
c0351e0 to
4f5f772
Compare
Runtime (Phase 1) and the cdk8s deploy (Phase 2) now load only native config, so the preset-replacer GENERATION machinery is dead. Remove it: - Delete resources/app_configs/replacer_*.json (19 files), src/replacers.rs, and the deployment_generator bin (+ its [[bin]] entry and the tempfile dev-dep). - service.rs: drop the replacer-annotation plumbing, the deploy-path config_to_preset/ prune_by_is_none calls, and the orphaned ComponentConfigsSerializationWrapper. Keep KEYS_TO_BE_REPLACED (still feeds the retained applicative_matches_app_configs guard's exclusion set). - Delete the 3 migration guard tests (deployment_files_are_up_to_date, replacer_config_entries_are_in_config, duplicate_config_entries). Keep the build_*_deserializes, applicative_matches_app_configs, and *_infra_matches_rust guards, and get_component_configs. The cdk8s configList field is presence-checked only (its targets live in a different directory and are not read under native), so deleting the base replacer JSONs leaves synth green. apollo_deployments: 9 tests pass; cdk8s synth green for all overlays. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
4f5f772 to
ece79f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Runtime (Phase 1) and the cdk8s deploy (Phase 2) now load only native config, so
the preset-replacer GENERATION machinery is dead. Remove it:
deployment_generator bin (+ its [[bin]] entry and the tempfile dev-dep).
prune_by_is_none calls, and the orphaned ComponentConfigsSerializationWrapper. Keep
KEYS_TO_BE_REPLACED (still feeds the retained applicative_matches_app_configs guard's
exclusion set).
replacer_config_entries_are_in_config, duplicate_config_entries). Keep the
build_*_deserializes, applicative_matches_app_configs, and *_infra_matches_rust guards,
and get_component_configs.
The cdk8s configList field is presence-checked only (its targets live in a different
directory and are not read under native), so deleting the base replacer JSONs leaves
synth green. apollo_deployments: 9 tests pass; cdk8s synth green for all overlays.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com