apollo_node_config,apollo_node: delete CONFIG_POINTERS data and pointer-remap from secrets bin#14652
Draft
nimrod-starkware wants to merge 1 commit into
Conversation
This was referenced Jun 28, 2026
Contributor
Author
This was referenced Jun 28, 2026
This was referenced Jun 28, 2026
452bc9e to
98aaff6
Compare
31be7f8 to
c0d2f48
Compare
98aaff6 to
198918e
Compare
…er-remap from secrets bin Pointer resolution was removed in Phase 1 and the equality guarantee is now enforced by the Phase-6 Validate check, so the CONFIG_POINTERS data is dead. Delete CONFIG_POINTERS, CONFIG_NON_POINTERS_WHITELIST, and POINTER_TARGET_VALUE. Rework the secrets-schema bin to collect is_private() params directly from dump() (no pointer-member->target remap); config_secrets_schema.json regenerates byte-identical (no secret param is a pointer member). Remove the transient private_parameters dump-derivation equivalence test (its drift-guard job is done now that the dump-derivation source is gone). The dumping.rs pointer builder fns + combine_config_map_and_pointers are retained for Phase 9 (still exercised by their tests). apollo_config 26/8, apollo_node_config 33, apollo_deployments 8 green; secrets schema sha unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
198918e to
853a39d
Compare
c0d2f48 to
4e8c344
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pointer resolution was removed in Phase 1 and the equality guarantee is now enforced by
the Phase-6 Validate check, so the CONFIG_POINTERS data is dead. Delete CONFIG_POINTERS,
CONFIG_NON_POINTERS_WHITELIST, and POINTER_TARGET_VALUE. Rework the secrets-schema bin to
collect is_private() params directly from dump() (no pointer-member->target remap);
config_secrets_schema.json regenerates byte-identical (no secret param is a pointer
member). Remove the transient private_parameters dump-derivation equivalence test (its
drift-guard job is done now that the dump-derivation source is gone).
The dumping.rs pointer builder fns + combine_config_map_and_pointers are retained for
Phase 9 (still exercised by their tests). apollo_config 26/8, apollo_node_config 33,
apollo_deployments 8 green; secrets schema sha unchanged.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com