Skip to content

apollo_node_config,apollo_node: delete CONFIG_POINTERS data and pointer-remap from secrets bin#14652

Draft
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/retire-preset-config-generationfrom
nimrod/jsonnet/delete-config-pointers
Draft

apollo_node_config,apollo_node: delete CONFIG_POINTERS data and pointer-remap from secrets bin#14652
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/retire-preset-config-generationfrom
nimrod/jsonnet/delete-config-pointers

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Pointer resolution was removed in Phase 1 and the equality guarantee is now enforced by
the Phase-6 Validate check, so the CONFIG_POINTERS data is dead. Delete CONFIG_POINTERS,
CONFIG_NON_POINTERS_WHITELIST, and POINTER_TARGET_VALUE. Rework the secrets-schema bin to
collect is_private() params directly from dump() (no pointer-member->target remap);
config_secrets_schema.json regenerates byte-identical (no secret param is a pointer
member). Remove the transient private_parameters dump-derivation equivalence test (its
drift-guard job is done now that the dump-derivation source is gone).

The dumping.rs pointer builder fns + combine_config_map_and_pointers are retained for
Phase 9 (still exercised by their tests). apollo_config 26/8, apollo_node_config 33,
apollo_deployments 8 green; secrets schema sha unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

…er-remap from secrets bin

Pointer resolution was removed in Phase 1 and the equality guarantee is now enforced by
the Phase-6 Validate check, so the CONFIG_POINTERS data is dead. Delete CONFIG_POINTERS,
CONFIG_NON_POINTERS_WHITELIST, and POINTER_TARGET_VALUE. Rework the secrets-schema bin to
collect is_private() params directly from dump() (no pointer-member->target remap);
config_secrets_schema.json regenerates byte-identical (no secret param is a pointer
member). Remove the transient private_parameters dump-derivation equivalence test (its
drift-guard job is done now that the dump-derivation source is gone).

The dumping.rs pointer builder fns + combine_config_map_and_pointers are retained for
Phase 9 (still exercised by their tests). apollo_config 26/8, apollo_node_config 33,
apollo_deployments 8 green; secrets schema sha unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/delete-config-pointers branch from 198918e to 853a39d Compare June 28, 2026 14:04
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-generation branch from c0d2f48 to 4e8c344 Compare June 28, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants