apollo_deployments: jsonnet applicative config#14479
Conversation
9e1729b to
5a15200
Compare
5a15200 to
9fe115f
Compare
PR SummaryMedium Risk Overview
Adds Placeholder URLs remain for L1/oracle endpoints (e.g. Infura template, Reviewed by Cursor Bugbot for commit 830827a. Bugbot is set up for automated code reviews on this repo. Configure here. |
9fe115f to
f4a4329
Compare
f4a4329 to
f93d240
Compare
| local recorderUrl = overrides.recorder_url; | ||
| local nativeClassesWhitelist = overrides.native_classes_whitelist; | ||
| local starknetUrl = overrides.starknet_url; | ||
| local versionedConstantsOverrides = overrides.versioned_constants_overrides; |
There was a problem hiding this comment.
Versioned constants incomplete
Medium Severity
versioned_constants_overrides is wired only from overrides.versioned_constants_overrides, without embedding the fixed limits that used to live in general_config.json (invoke_tx_max_n_steps, max_recursion_depth, validate_max_n_steps, etc.). Only max_n_events is per-environment in KEYS_TO_BE_REPLACED, so sparse overrides can omit the other fields and change execution limits from the prior deployment defaults.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit f93d240. Configure here.
| lag_interval_seconds: 900, | ||
| max_cache_size: 100, | ||
| query_timeout_sec: 10, | ||
| url_header_list: 'https://api.example.com/api', |
There was a problem hiding this comment.
L1 oracle URLs hardcoded
Medium Severity
l1_gas_price_provider_config sets eth_to_strk_oracle_config.url_header_list and strk_to_usd_oracle_config.url_header_list to fixed https://api.example.com/api strings. Those endpoints were not in applicative app configs before; they came from deployment secrets. Baking in placeholder URLs can make gas-price oracles call the wrong host if secrets no longer override these fields in the new jsonnet flow.
Reviewed by Cursor Bugbot for commit f93d240. Configure here.
3eebb75 to
8b8707c
Compare
8b8707c to
f92f05c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f92f05c. Configure here.
f92f05c to
05c9dd4
Compare
05c9dd4 to
830827a
Compare



No description provided.