Skip to content

apollo_deployments: test overrides list match#14480

Draft
nimrod-starkware wants to merge 1 commit into
graphite-base/14480from
nimrod/jsonnet/overrides-test
Draft

apollo_deployments: test overrides list match#14480
nimrod-starkware wants to merge 1 commit into
graphite-base/14480from
nimrod/jsonnet/overrides-test

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/applicative-jsonnet branch from 3c60f09 to 9e1729b Compare June 14, 2026 11:55
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/overrides-test branch from 0514557 to 123caa7 Compare June 14, 2026 11:56
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/applicative-jsonnet branch from 9e1729b to 5a15200 Compare June 14, 2026 14:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/overrides-test branch from 123caa7 to 24daabc Compare June 14, 2026 14:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/overrides-test branch from 24daabc to 69cf6dd Compare June 15, 2026 07:25
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/applicative-jsonnet branch from 5a15200 to 9fe115f Compare June 15, 2026 07:25
@nimrod-starkware nimrod-starkware self-assigned this Jun 16, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review June 16, 2026 12:09
@cursor

cursor Bot commented Jun 16, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only changes in apollo_deployments; no runtime deployment or config generation behavior is modified.

Overview
Adds a deployment test that keeps Rust’s KEYS_TO_BE_REPLACED set aligned with what applicative_config.libsonnet actually reads from overrides.

The harness derives expected override paths from KEYS_TO_BE_REPLACED (collapsing optional .#is_none roots), injects path-tagged sentinel strings at each path, evaluates function(overrides), and asserts every declared path’s sentinel shows up in the output. Evaluation/serialization failures catch reads of undeclared paths or illegal sub-field access on optional configs.

Wired through keys_to_be_replaced_are_covered_by_override_schema in deployment_definitions_test.rs, alongside the existing applicative vs app_configs check.

Reviewed by Cursor Bugbot for commit aea4a35. Bugbot is set up for automated code reviews on this repo. Configure here.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/applicative-jsonnet branch from 9fe115f to f4a4329 Compare June 16, 2026 12:10
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/overrides-test branch from 69cf6dd to 4824f43 Compare June 16, 2026 12:10
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/applicative-jsonnet branch from f4a4329 to f93d240 Compare June 17, 2026 12:07
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/overrides-test branch from 4824f43 to 9872396 Compare June 17, 2026 12:07
The applicative config reads its per-environment values from `overrides`,
keyed by the same paths the Rust deployment marks replaceable
(KEYS_TO_BE_REPLACED). Add a test that the two agree, by evaluating the
applicative `function(overrides)` with a sentinel placed at every
expected override path and checking which sentinels flow into the output
— so it tracks actual consumption and is insensitive to the jsonnet's
formatting. A sentinel that never appears is a replacer key the
applicative never reads; an override the applicative reads but
KEYS_TO_BE_REPLACED does not declare makes jsonnet fail to evaluate.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware nimrod-starkware changed the base branch from nimrod/jsonnet/generation-module to graphite-base/14480 June 28, 2026 10:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/overrides-test branch from aea4a35 to c21cf85 Compare June 28, 2026 10:30
@nimrod-starkware nimrod-starkware changed the base branch from graphite-base/14480 to nimrod/jsonnet/applicative-defaults-parity June 28, 2026 10:31
This was referenced Jun 28, 2026
@nimrod-starkware nimrod-starkware changed the base branch from nimrod/jsonnet/applicative-defaults-parity to graphite-base/14480 June 28, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants