Skip to content

apollo_deployments: check applicative config matches deployed app_configs#14489

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/node-config-deserializationfrom
nimrod/jsonnet/applicative-defaults-parity
Open

apollo_deployments: check applicative config matches deployed app_configs#14489
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/node-config-deserializationfrom
nimrod/jsonnet/applicative-defaults-parity

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/node-config-deserialization branch from dca1eac to c7ee7a9 Compare June 15, 2026 05:48
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/applicative-defaults-parity branch 2 times, most recently from 5dfd0d9 to ec0af21 Compare June 15, 2026 07:25
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/node-config-deserialization branch from c7ee7a9 to 78fbd17 Compare June 15, 2026 07:25
@nimrod-starkware nimrod-starkware changed the title apollo_deployments: applicative config defaults match rust defaults apollo_deployment: check applicative config matches deployed app_configs Jun 15, 2026
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/applicative-defaults-parity branch from ec0af21 to ba56ad9 Compare June 16, 2026 07:04
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/node-config-deserialization branch from 78fbd17 to f226a9e Compare June 16, 2026 08:28
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/applicative-defaults-parity branch 2 times, most recently from e0f2483 to aaf7c60 Compare June 16, 2026 12:10
@nimrod-starkware nimrod-starkware self-assigned this Jun 16, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review June 16, 2026 12:11
@cursor

cursor Bot commented Jun 16, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test and deployment-config parity only; no runtime behavior changes beyond aligning one numeric literal with integer JSON.

Overview
Adds a CI test that the consolidated jsonnet build’s applicative defaults stay aligned with the committed app_configs/*.json layer (non-overridable deployment values).

The check evaluates build('consolidated', testing overrides), round-trips through SequencerNodeConfig and config_to_preset, merges all base app_configs JSON (skipping replacer_*), and compares keys while excluding overridable keys (KEYS_TO_BE_REPLACED), secrets, config pointers, and components.*. Supporting pieces: test_applicative_matches_app_configs in jsonnet.rs, is_path_prefix for dotted-key subtree matching, and BASE_APP_CONFIGS_DIR_PATH made pub(crate) for the merger.

l1_events_scraper_config.l1_block_time_seconds is normalized from 12.0 to 12 in jsonnet and the matching app config JSON so values match integer serialization from the config dump.

Reviewed by Cursor Bugbot for commit 5ef42b9. Bugbot is set up for automated code reviews on this repo. Configure here.

@nimrod-starkware nimrod-starkware changed the title apollo_deployment: check applicative config matches deployed app_configs apollo_deployments: check applicative config matches deployed app_configs Jun 16, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 19f89f8. Configure here.

Comment thread crates/apollo_deployments/src/jsonnet.rs
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/applicative-defaults-parity branch from 19f89f8 to 7a52c90 Compare June 28, 2026 08:19
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/node-config-deserialization branch from f14f753 to 885db66 Compare June 28, 2026 08:19
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/node-config-deserialization branch from 885db66 to f7c1bae Compare June 28, 2026 10:30
@nimrod-starkware nimrod-starkware force-pushed the nimrod/jsonnet/applicative-defaults-parity branch from 7a52c90 to df3b806 Compare June 28, 2026 10:30
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants